Scoop logging #3417
Merged
Scoop logging #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
bensteinberg
approved these changes
Oct 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3417 +/- ##
===========================================
- Coverage 68.89% 68.82% -0.07%
===========================================
Files 53 53
Lines 7297 7304 +7
===========================================
Hits 5027 5027
- Misses 2270 2277 +7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a couple varieties of error go by, capturing with Scoop.
This PR adds special handling for two categories of error, so that we can a) more easily count and track occurrences over time; b) get easier-to-read reports when those errors do happen (saving more verbose logging for anomalies); c) direct them to the 'warning' log instead of the 'error' log, to quiet the stream.
This PR also updates
watchdogon the side... turns out this version of Werkzeug requires that tweak for our dev setup to work as expected.