Skip to content

Commit

Permalink
rename cleaup policy type from 'Compaction' to 'Compact' (Azure#24056)
Browse files Browse the repository at this point in the history
'Compact' is already implemented in the resource provider and is consistent with using verb such as type 'Delete'
  • Loading branch information
kevxms authored and harryli0108 committed Jul 28, 2023
1 parent 676821e commit 66d4a86
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@
"description": "Enumerates the possible values for cleanup policy",
"enum": [
"Delete",
"Compaction"
"Compact"
],
"x-ms-enum": {
"name": "CleanupPolicyRetentionDescription",
Expand All @@ -284,12 +284,12 @@
"retentionTimeInHours": {
"format": "int64",
"type": "integer",
"description": "Number of hours to retain the events for this Event Hub. This value is only used when cleanupPolicy is Delete. If cleanupPolicy is Compaction the returned value of this property is Long.MaxValue "
"description": "Number of hours to retain the events for this Event Hub. This value is only used when cleanupPolicy is Delete. If cleanupPolicy is Compact the returned value of this property is Long.MaxValue "
},
"tombstoneRetentionTimeInHours": {
"format": "int32",
"type": "integer",
"description": "Number of hours to retain the tombstone markers of a compacted Event Hub. This value is only used when cleanupPolicy is Compaction. Consumer must complete reading the tombstone marker within this specified amount of time if consumer begins from starting offset to ensure they get a valid snapshot for the specific key described by the tombstone marker within the compacted Event Hub"
"description": "Number of hours to retain the tombstone markers of a compacted Event Hub. This value is only used when cleanupPolicy is Compact. Consumer must complete reading the tombstone marker within this specified amount of time if consumer begins from starting offset to ensure they get a valid snapshot for the specific key described by the tombstone marker within the compacted Event Hub"
}
},
"description": "Properties to configure retention settings for the eventhub"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}
},
"retentionDescription": {
"cleanupPolicy": "Compaction",
"cleanupPolicy": "Compact",
"retentionTimeInHours": 96,
"tombstoneRetentionTimeInHours": 1
}
Expand Down Expand Up @@ -65,7 +65,7 @@
"sizeLimitInBytes": 10485763
},
"retentionDescription": {
"cleanupPolicy": "Compaction",
"cleanupPolicy": "Compact",
"retentionTimeInHours": 96,
"tombstoneRetentionTimeInHours": 1
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"sizeLimitInBytes": 10485763
},
"retentionDescription": {
"cleanupPolicy": "Compaction",
"cleanupPolicy": "Compact",
"retentionTimeInHours": 96,
"tombstoneRetentionTimeInHours": 1
}
Expand Down

0 comments on commit 66d4a86

Please sign in to comment.