Attempt to vend vec_2d code to cuproj and use in cuprojshim #2
+275
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
merged commit a12533d
into
harrism:feature/projection/python-bindings-cuprojshim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
I went down the vending code route for a little bit and still run into blockers. There is device code in vec_2d class that's used in cuproj library, so we need to vend the device code as well. This makes vec_2d not completely a host only library and makes whichever interface that we want to expose in cuprojshim not host-only code either. And whichever cython interface that contains device code will throw the build system off.
We need to think of a way to hide away the device code for vec_2d or move the device code of vec_2d to outside of the class (as standalone functions, albeit it might be slower to compile due to ADL)