Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup workspace tabs #92

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Apr 3, 2023

Fixes #85. Also, while we're at it, removes the badge labels because they do something different than I thought they did lol.

Also, while we're here, ensure that the "close on saving" function actually commits the changes by building iteratively.

@jonko0493 jonko0493 requested a review from WiIIiam278 April 3, 2023 15:39
@jonko0493 jonko0493 self-assigned this Apr 3, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to not block! following on from discord convo, we realised the tab index you had open isnt actually being saved anyway so its okay to just open the first in the list to solve this issue

@jonko0493 jonko0493 merged commit 141e9c8 into haroohie-club:main Apr 3, 2023
@jonko0493 jonko0493 deleted the FixupWorkspaceTabs branch April 3, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs are loaded off screen when reloading project workspace
2 participants