Add crash handler on Windows, enable crash logging on Mac #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux: 🤷♀️
This adds a simple crash handler on Windows that can catch exceptions prior to a crash and log them to the log file. We add a special
LogCrashfunction to theLoopyLoggerso that we don't pop a message box when logging that particular error.WPF is able to catch these exceptions because they are its native exceptions; however, we're not so lucky on Mac and Linux. The end result here is that we need to be better at exception handling generally. In the meantime though, I've enabled crash logging on Mac which will give stack traces in the standard macOS "Report this error" dialog, so we can tell people to do that to get useful logs on that platform at least.
Fixes #79.