Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial map items/editors work, add map characters tab to script editor #45

Merged
merged 10 commits into from
Mar 8, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Mar 5, 2023

image
image

Adds map previews with pathing map overlay to the map editor as well as adding a "Map Characters" tab to the script editor which allows for editing the chibis, facing directions, and associated script blocks for the chibis on the map, as well as allowing chibis to be removed. You can also add new chibis and drag and drop them around the map.

@jonko0493 jonko0493 self-assigned this Mar 5, 2023
@jonko0493 jonko0493 changed the title Initial map items Initial map items/editors work, add map characters tab to script editor Mar 5, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extremely cool

src/SerialLoops/Editors/ScriptEditor.cs Outdated Show resolved Hide resolved
DropDown chibisSelectorDropDown = new();
chibisSelectorDropDown.Items.AddRange(_project.Items.Where(i => i.Type == ItemDescription.ItemType.Chibi).Select(c => new ListItem { Key = c.Name, Text = c.Name }));
chibisSelectorDropDown.SelectedKey = chibi.Name;
DropDown facingDirectionDropDown = new()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for this a 2x2 button array? Can add some nice icons for it, or just use arrows for now, and may be more intuitive. Will also want to reuse in the chibi editor itself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is a future PR thing bc I couldn't really get it looking nice in this one.

@jonko0493 jonko0493 marked this pull request as draft March 7, 2023 08:07
@jonko0493
Copy link
Member Author

Converting this to a draft for now bc I'm going to try to get drag and drop fully working, but that will take more time than I have rn lol.

@jonko0493 jonko0493 marked this pull request as ready for review March 8, 2023 05:09
@jonko0493 jonko0493 merged commit 094a8c8 into haroohie-club:main Mar 8, 2023
@jonko0493 jonko0493 deleted the InitialMapItems branch March 8, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants