Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete parameter editing to the script editor #39

Merged
merged 31 commits into from
Feb 26, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 19, 2023

Adds the ability to edit all script command parameters (except for the chess-related parameters which are still poorly-understood).

Also adds some other neat things:

  • A "searchable text" field to make searching through files easier -- might redo how this is done at some point but was useful
  • Bugfix for the NONE selection crash
  • Fixes a macOS context menu crash (probably)
  • Adds Dialogue Properties items
  • Adds the background palette effects to the preview (with color matrices!!)
  • Adds a "background export" button to the background editor, allowing for exporting images
  • Adds new RE info to the topic & group selection editors
  • Adds half-width text replacement to most files (TODO: conditionalize it on config)
  • Adds auto-nice quotes to text editors
  • Fixup tab context menus to work on tabs

@jonko0493 jonko0493 requested a review from WiIIiam278 February 19, 2023 07:53
@jonko0493 jonko0493 self-assigned this Feb 19, 2023
@jonko0493 jonko0493 marked this pull request as ready for review February 25, 2023 07:48
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoroughly awesome work!!

src/SerialLoops/Editors/ScriptEditor.cs Show resolved Hide resolved
src/SerialLoops/Editors/ScriptEditor.cs Outdated Show resolved Hide resolved
src/SerialLoops/Editors/ScriptEditor.cs Outdated Show resolved Hide resolved
src/SerialLoops/Editors/ScriptEditor.cs Show resolved Hide resolved
src/SerialLoops.Lib/Items/ScriptItem.cs Show resolved Hide resolved
src/SerialLoops.Lib/Util/IProgressTracker.cs Show resolved Hide resolved
src/SerialLoops/Editors/DialogueConfigEditor.cs Outdated Show resolved Hide resolved
src/SerialLoops/Editors/ScriptEditor.cs Show resolved Hide resolved
@jonko0493 jonko0493 merged commit 6b8ca5d into haroohie-club:main Feb 26, 2023
@jonko0493 jonko0493 deleted the FullScriptEditing branch February 26, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants