Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure user directory, refactor for testability, add a ton of tests #36

Merged
merged 10 commits into from
Feb 17, 2023
Merged

Restructure user directory, refactor for testability, add a ton of tests #36

merged 10 commits into from
Feb 17, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 16, 2023 •
edited
Loading

Three parts to this one:

  • I wanted to be able to store logs in the user directory so they were easier to find. In order to do that, I made a "Projects" subdirectory for that all the projects go into. I also moved the recent projects JSON file to the user directory.
  • I wanted to be able to test more things. UI testing is very hard, so I refactored a bunch of our logic that didn't rely on UI into the library so it could be tested.
  • I wrote tests and run those tests over every item we have loaded. The tests are displayed separately as test cases for easy navigation. The tests tab on azure pipelines should show it nicely.

Additionally, I just snuck in an update to BG_DISPTEMP bc I know what the unknown parameter does now.

@jonko0493 jonko0493 self-assigned this Feb 16, 2023
WiIIiam278
WiIIiam278 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks really good.
Made me realize I forgot to add the progress dialog to project creation -- probably should do that.

src/SerialLoops/Controls/ItemContextMenu.cs Show resolved Hide resolved
@jonko0493 jonko0493 merged commit 680e52a into haroohie-club:main Feb 17, 2023
@jonko0493 jonko0493 deleted the RestructureUserDirectory branch February 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiIIiam278 WiIIiam278 WiIIiam278 approved these changes

Assignees

@jonko0493 jonko0493

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonko0493 @WiIIiam278