-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout editor #349
Merged
Merged
Layout editor #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259.
The end result of this will necessarily have a lot of hardcoding in it, but hopefully less hardcoding than we currently have. Or maybe just a different, more-researched hardcoding.
Putting this in draft right now as it's not done, but I would appreciate a once-over for the UI as it exists currently.@WiIIiam278 , feel free to make any edits you wantand commit them directly to this branch if you'd likeyou can commit directly to the branch, or you can wait and do it in a separate PR.Added support for SKControl and SKGLControl, Skia-based graphics-accelerated canvas controls that seem very legit and performant! Might want to port some of our other stuff to using them.