Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-plat IWavePlayer to eliminate loading times for sound players #34

Merged
merged 28 commits into from
Feb 14, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 14, 2023

This structurally changes the project a bit as we needed the ability to add native code. Everything else works the same.

Notable limitation: on Windows, you can play as many sounds at the same time as you like. However, on Mac and Linux, you can only play one sound at a time.

Also slipped in a couple of fixes to the script preview renderer, namely:

  • Added SET_READ_FLAG as a command that prohibits graph edges (possibly need to rename that command to BACK), which fixes rendering in topic files and a few other places
  • Sprite exits are handled after dialogue is advanced, so now the sprite renderer handles those on the following command

Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (well, sounds!) really good, works a treat on Mac, so much faster. Did notice that voiced line references don't populate quite right on this for some reason, but that's probably unrelated.

@jonko0493 jonko0493 merged commit 77ac229 into haroohie-club:main Feb 14, 2023
@jonko0493 jonko0493 deleted the AddPlatformSpecificCode branch February 14, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants