-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cross-plat IWavePlayer to eliminate loading times for sound players #34
Merged
jonko0493
merged 28 commits into
haroohie-club:main
from
jonko0493:AddPlatformSpecificCode
Feb 14, 2023
Merged
Use cross-plat IWavePlayer to eliminate loading times for sound players #34
jonko0493
merged 28 commits into
haroohie-club:main
from
jonko0493:AddPlatformSpecificCode
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks (well, sounds!) really good, works a treat on Mac, so much faster. Did notice that voiced line references don't populate quite right on this for some reason, but that's probably unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This structurally changes the project a bit as we needed the ability to add native code. Everything else works the same.
Notable limitation: on Windows, you can play as many sounds at the same time as you like. However, on Mac and Linux, you can only play one sound at a time.
Also slipped in a couple of fixes to the script preview renderer, namely:
SET_READ_FLAG
as a command that prohibits graph edges (possibly need to rename that command toBACK
), which fixes rendering in topic files and a few other places