Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve save editing UI #339

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

WiIIiam278
Copy link
Member

@WiIIiam278 WiIIiam278 commented Jan 29, 2024

Improves the Save Editing UI and dramatically increasesDE-creases (!) save load times.

This PR features save slot previews, a tabbed interface for editing saves, and pagination/filtering for setting flags.

Screeenshots

image
image
image
image
image

@WiIIiam278 WiIIiam278 requested a review from jonko0493 January 29, 2024 19:37
@WiIIiam278 WiIIiam278 self-assigned this Jan 29, 2024
@jonko0493
Copy link
Member

hopefully it dramatically decreases the load times :P

Copy link
Member

@jonko0493 jonko0493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. I've left feedback that should be addressed, but approving to unblock you either way.

src/SerialLoops.Lib/SaveFile/SaveFilePreview.cs Outdated Show resolved Hide resolved
src/SerialLoops.Lib/SaveFile/SaveFilePreview.cs Outdated Show resolved Hide resolved
src/SerialLoops.Lib/SaveFile/SaveFilePreview.cs Outdated Show resolved Hide resolved
src/SerialLoops/Dialogs/SaveEditorDialog.cs Outdated Show resolved Hide resolved
@jonko0493 jonko0493 merged commit f4af006 into haroohie-club:main Jan 29, 2024
4 checks passed
@WiIIiam278 WiIIiam278 deleted the improve-save-editing branch January 29, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants