Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASM hack QoL changes & upgrade to .NET 8.0 #314

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

jonko0493
Copy link
Member

Closes #306. Closes #307. Fixes #308. Closes #311.

The switch to .NET 8.0 makes this change look bigger than it is. While upgrading the choku lib to .NET 8, I made a bunch of underlying breaking changes to its APIs (just renaming classes and such) which is why you see a bunch of changes throughout.

Highlights:

  • .NET 8 upgrade, including a bunch of small changes to code style that come with that upgrade to a newer C#
  • Upgrade a ton of packages along the way, including bumping NitroPacker and the Choku lib to their .NET 8 versions
  • Before, if a patch failed to apply, we left the build directory in an unclean state (with patch files just sitting there). New code explicitly reverts those patches and deletes unnecessary directories.
  • Added functionality to NitroPacker to allow naming the docker containers we create when patching, which gives us the handy ability to call docker rm afterwards and clean up those containers
  • Surfaced the make/docker logging to the user through a loading modal which will hopefully make that process less confusing

@jonko0493 jonko0493 requested a review from WiIIiam278 January 11, 2024 00:28
@jonko0493 jonko0493 self-assigned this Jan 11, 2024
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested standard test ASM hack application (non-dockerized) on my mac, and it seems to work just fine (after an IDE upgrade to a version that supports 8!). After that, no friction!

I'll give Docker testing a go at some point soon - I love me a nice loading modal!

@jonko0493 jonko0493 merged commit c54451e into haroohie-club:main Jan 12, 2024
4 checks passed
@jonko0493 jonko0493 deleted the AsmHackQolChanges branch January 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants