ASM hack QoL changes & upgrade to .NET 8.0 #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306. Closes #307. Fixes #308. Closes #311.
The switch to .NET 8.0 makes this change look bigger than it is. While upgrading the choku lib to .NET 8, I made a bunch of underlying breaking changes to its APIs (just renaming classes and such) which is why you see a bunch of changes throughout.
Highlights:
docker rm
afterwards and clean up those containers