-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SFX items & Character voice font/text timer preview/editing #293
Merged
jonko0493
merged 13 commits into
haroohie-club:main
from
jonko0493:VoiceFontAndSfxMaybe
Jun 26, 2023
Merged
Add SFX items & Character voice font/text timer preview/editing #293
jonko0493
merged 13 commits into
haroohie-club:main
from
jonko0493:VoiceFontAndSfxMaybe
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works flawlessly -- excellent job! (barring fixing up those tests) ah you did this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212. Closes #245.
This adds SFX items (but does not make them editable). It allows for previewing them with (unfortunately) a new sound player that uses modified versions of Gota7's SDAT tech used in Nitro Studio 2. I also added the ability to export a wav of an SFX using the same tech.
Additionally, this shows the bank that the SFX uses, and the groups which contain the SFX. The groups in particular are important as they are what determine which sounds are playable in a given scene. It's unknown where the game decides which groups to load for a given scene at this time.
Finally, now that we can preview the voice font, we allow specifying a different sound effect to use and allow changing the text timer as well.
Oh, and we bump the versions to 0.3 preview now. :)