Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build capabilities #23

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 7, 2023

Adds build capabilities and a preferences menu for adjusting config. Currently does not build ASM hacks, just the archives.

Still needs to be tested on Mac & Linux before merging.

@jonko0493 jonko0493 self-assigned this Feb 7, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion was to be the toolbar, but you sorted that. Nice work all round, will look into doing icons for that soon.

My only comment is the static inclusion of e50_newsize.png -- this seems to be the FanTL version, so doesn't this break the jp dialogue? I imagine it may also cause issues where say, another language wishes to add additional nonlatin characters (Korean, maybe). Could we pull this from the assets repo to maintain compatibility with future languages that may need to customize the fontset? Everything else looks great though

@jonko0493
Copy link
Member Author

So re: the font -- it does break Japanese characters, but it isn't included if language is set to Japanese. For now, I think we should avoid referencing the Assets repo at all and encourage hackers to use the translated ROM as a base if they want the English language graphics & text by default. Though now that you mention it, the inclusion of the font isn't strictly necessary since it's already included with the translated ROM, so actually now that you mention it I'm just going to dump it entirely lol.

@jonko0493 jonko0493 merged commit 2e76b1e into haroohie-club:main Feb 7, 2023
@jonko0493 jonko0493 deleted the BuildTime branch February 7, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants