-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New script editor!! #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a spin.. it's very cool! looks really good, too -- still some stuff to sort out with certain param/command types, but this is a great start!
I'll lend my UI thoughts: This is a much, much better layout, good idea! I do have a few suggestions, though:
- I think the best thing we can do in terms of UI is remove some of the text by replacing it with the relevant images (e.g. character emotes) and just adding some more icons in general (e.g. file type icons on the relevant select dropdown controls). Perhaps a little icon could be used to represent characters, (kyon, haruhi, etc), too.
- The preview listitems should probably have increased padding and be slightly wider, perhaps?
- We should probably replace certain dropdowns (like of character sprites) with select menus that can be easily filtered (or look if eto has a searchable dropdown control)
- I also think we should probably change the command parameters (which are currently just taken from your spec) to be more legible (i.e. "spriteEntranceTransition" --> "Sprite Entrance Transition") since they're there for UI and not really for internal use or anything.
- Consider putting each parameter on its own line (less compact, but probably easier to use and familiarize this way I imagine)
Future stuff to consider:
- With DIALOGUE and SELECT commands I definitely also think having a preview in-built would be an excellent idea, too. This may actually self-address the need to add image previews in so many of the parameter edit controls.
- Some sort of UI for adding, removing and re-ordering commands, which may be hard with a listbox
Additionally, we need to have space for editing the other sections of the event file as well, most notably the properties for the iso map, the starting chibis, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a spin earlier and it's really great. Still a few things that don't save properly and things to add to the preview system like the UI, dialogue and character sprites but I think this works very well indeed for pass 1
The listbox looks ugly on linux but I don't really care since we're gonna change it anyway.
Supports preview rendering for backgrounds and top screen chibis!