Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script editor!! #21

Merged
merged 13 commits into from
Feb 6, 2023
Merged

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 4, 2023

image

The listbox looks ugly on linux but I don't really care since we're gonna change it anyway.

Supports preview rendering for backgrounds and top screen chibis!

@jonko0493 jonko0493 requested a review from WiIIiam278 February 4, 2023 20:58
@jonko0493 jonko0493 self-assigned this Feb 4, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a spin.. it's very cool! looks really good, too -- still some stuff to sort out with certain param/command types, but this is a great start!

I'll lend my UI thoughts: This is a much, much better layout, good idea! I do have a few suggestions, though:

  • I think the best thing we can do in terms of UI is remove some of the text by replacing it with the relevant images (e.g. character emotes) and just adding some more icons in general (e.g. file type icons on the relevant select dropdown controls). Perhaps a little icon could be used to represent characters, (kyon, haruhi, etc), too.
  • The preview listitems should probably have increased padding and be slightly wider, perhaps?
  • We should probably replace certain dropdowns (like of character sprites) with select menus that can be easily filtered (or look if eto has a searchable dropdown control)
  • I also think we should probably change the command parameters (which are currently just taken from your spec) to be more legible (i.e. "spriteEntranceTransition" --> "Sprite Entrance Transition") since they're there for UI and not really for internal use or anything.
  • Consider putting each parameter on its own line (less compact, but probably easier to use and familiarize this way I imagine)

Future stuff to consider:

  • With DIALOGUE and SELECT commands I definitely also think having a preview in-built would be an excellent idea, too. This may actually self-address the need to add image previews in so many of the parameter edit controls.
  • Some sort of UI for adding, removing and re-ordering commands, which may be hard with a listbox

@jonko0493
Copy link
Member Author

jonko0493 commented Feb 5, 2023

  • Completely agree on replacing the UI elements with images where possible and adding icons. I'd imagine this would also dovetail with the suggestion for specific selection menus. My main concern for that is caching & perf, but I'm sure we can optimize it to work okay.
  • The listbox has a few too many limitations and needs to go and be replaced with something custom – perhaps reusing sections to some extent? The commands need to be organized into script blocks in order to be able to make sense of them, for one thing, and like you said be able to do add/delete/replace. I actually think something like our existing item tree would work well for that with some tweaks.
  • I was planning on having a built-in preview for every command eventually, and I'd really like to have it be cumulative, i.e., the current command accounts for the state defined by previous commands to display what the screen looks like.
  • I'll try putting each parameter on its own line for sure.

Additionally, we need to have space for editing the other sections of the event file as well, most notably the properties for the iso map, the starting chibis, etc.

@jonko0493 jonko0493 marked this pull request as ready for review February 6, 2023 00:58
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a spin earlier and it's really great. Still a few things that don't save properly and things to add to the preview system like the UI, dialogue and character sprites but I think this works very well indeed for pass 1

@jonko0493 jonko0493 merged commit a88d383 into haroohie-club:main Feb 6, 2023
@jonko0493 jonko0493 deleted the ChangeScriptEditor branch February 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants