Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "dialogue config" with "character" abstraction that can be used instead of Speakers and add nameplate editor #181

Merged
merged 6 commits into from
May 13, 2023
Merged

Replace "dialogue config" with "character" abstraction that can be used instead of Speakers and add nameplate editor #181

merged 6 commits into from
May 13, 2023

Conversation

jonko0493
Copy link
Member

Closes #91.

@jonko0493 jonko0493 requested a review from WiIIiam278 May 13, 2023 15:25
@jonko0493 jonko0493 self-assigned this May 13, 2023
WiIIiam278
WiIIiam278 approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing :) Two things as well:

Only other thing is that it's a bit weird that we're using both an underscore and a space in the names, would be nice to have them consistent (either always w/ or w/o an underscore)
image

src/SerialLoops.Lib/DefaultCharacters.en.json Outdated Show resolved Hide resolved
src/SerialLoops.Lib/DefaultCharacters.en.json Outdated Show resolved Hide resolved
@WiIIiam278 WiIIiam278 mentioned this pull request May 13, 2023
Closed
@jonko0493
Copy link
Member Author

As for the spaces & underscores: honestly, I don't want to write something that translates between the two. I think it's hacky and ultimately unnecessary. I'm okay with the stylistic inconsistency, personally.

@jonko0493 jonko0493 merged commit a190a5a into haroohie-club:main May 13, 2023
@jonko0493 jonko0493 deleted the AddCharacterItems branch May 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiIIiam278 WiIIiam278 WiIIiam278 approved these changes

Assignees

@jonko0493 jonko0493

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Dialogue Config items with "Character" items and allow editing nameplates
2 participants
@jonko0493 @WiIIiam278