Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script templates feature, add one basic script template #148

Merged
merged 10 commits into from
Apr 11, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Apr 11, 2023

Closes #102, but should probably open a follow-up issue for a future milestone to add more templates.

Adds "script template" functionality, which basically is the ability to quickly add a set of predefined commands to your script. The basic one I've created is for adding the most common boilerplate commands to SCRIPT00. In the future, the functionality can and should be expanded.

@WiIIiam278 there are a lot of UI improvements here that could be made -- most notably, we need an icon for apply templates. Please feel free to commit any changes to UI directly to this branch.

@jonko0493 jonko0493 self-assigned this Apr 11, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

Only thing I would say is that if you apply a template on an existing file it can be a bit confusing -- maybe some templates could be marked as "starter" templates and give a warning that adding them to a file may have unintended consequences?

also I'd say when we add new script creating we should display the template panel as the first thing you see (& can show starter templates on there)

src/SerialLoops.Lib/Script/ScriptTemplate.cs Show resolved Hide resolved
src/SerialLoops.Lib/Script/ScriptTemplates.cs Outdated Show resolved Hide resolved
src/SerialLoops/Dialogs/ScriptTemplateSelectorDialog.cs Outdated Show resolved Hide resolved
src/SerialLoops/Editors/ScriptEditor.cs Outdated Show resolved Hide resolved
@jonko0493 jonko0493 merged commit 5aec136 into haroohie-club:main Apr 11, 2023
@jonko0493 jonko0493 deleted the ScriptTemplates branch April 11, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script file templates
2 participants