Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chibi items #14

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Add chibi items #14

merged 4 commits into from
Feb 2, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Feb 2, 2023

image

Animation can stutter a little, but that's okay for now at least Looks like this might only be the case on resource-starved machines lol, worked fine on all my other test machines. Chibis are displayed and there's a dropdown to select which chibi to view.

@jonko0493 jonko0493 requested a review from WiIIiam278 February 2, 2023 13:06
@jonko0493 jonko0493 self-assigned this Feb 2, 2023
@jonko0493 jonko0493 changed the title Add chibi items/editor Add chibi items Feb 2, 2023
@WiIIiam278
Copy link
Member

I do think the frames would be better along the bottom with a way of pausing/playing the animation at each frame (ideally it'd show which frame you were on, too, kind of like a timeline). Maybe in a second pass? This looks great though :)

@jonko0493
Copy link
Member Author

@WiIIiam278 I think we're gonna want to refactor all of these eventually anyway, yeah.

@jonko0493 jonko0493 merged commit 47be581 into haroohie-club:main Feb 2, 2023
@jonko0493 jonko0493 deleted the AddChibiItems branch February 2, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants