Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash removing map characters from EV1_001 on Mac #129

Closed
WiIIiam278 opened this issue Apr 8, 2023 · 3 comments · Fixed by #133
Closed

Crash removing map characters from EV1_001 on Mac #129

WiIIiam278 opened this issue Apr 8, 2023 · 3 comments · Fixed by #133
Assignees
Labels
bug Something isn't working critical Used for critical bugs (things that are causing crashes) macos Used on issues that affect macOS specifically

Comments

@WiIIiam278
Copy link
Member

item: EV1_001

  1. Navigate to the map characters editor
  2. Click "remove characters..."
  3. Crash :(
@WiIIiam278 WiIIiam278 added the bug Something isn't working label Apr 8, 2023
@jonko0493 jonko0493 added critical Used for critical bugs (things that are causing crashes) macos Used on issues that affect macOS specifically labels Apr 8, 2023
@jonko0493 jonko0493 self-assigned this Apr 9, 2023
@jonko0493 jonko0493 moved this to In Progress in Serial Loops Apr 9, 2023
@jonko0493
Copy link
Member

Also crashes when attempting to remove starting chibis.

@jonko0493
Copy link
Member

Crash log from starting chibis:

Application Specific Information:
Performing @selector(__monomac_internal_ActionDispatcher_activated:) from sender Eto.Mac.Forms.Controls.EtoButton 0x7fbb46c5d940
System.NullReferenceException: Object reference not set to an instance of an object.
at SerialLoops.Editors.ScriptEditor.UpdatePreview() in /Users/jonko/Code/SerialLoops/src/SerialLoops/Editors/ScriptEditor.cs:line 1435
at SerialLoops.Editors.ScriptEditor.<>c__DisplayClass21_0.<GetStartingChibisLayout>b__18() in /Users/jonko/Code/SerialLoops/src/SerialLoops/Editors/ScriptEditor.cs:line 439
at SerialLoops.Editors.ScriptEditor.<>c__DisplayClass21_0.<GetStartingChibisLayout>b__7(Object o, EventArgs args) in /Users/jonko/Code/SerialLoops/src/SerialLoops/Editors/ScriptEditor.cs:line 439
at Eto.PropertyStore.TriggerEvent[T](Object key, Object sender, T args)
at Eto.Forms.Button.OnClick(EventArgs e)
at Eto.Forms.Button.Callback.OnClick(Button widget, EventArgs e)
at Eto.Mac.Forms.Controls.ButtonHandler`2.OnActivated()
at Eto.Mac.Forms.Controls.ButtonHandler`2.HandleActivated(Object sender, EventArgs e)
abort() called

@jonko0493
Copy link
Member

This is caused by attempting to update the preview when there is no preview present. If a command has been selected, no crash occurs.

jonko0493 added a commit to jonko0493/SerialLoops that referenced this issue Apr 9, 2023
@jonko0493 jonko0493 mentioned this issue Apr 9, 2023
@jonko0493 jonko0493 moved this from In Progress to In PR in Serial Loops Apr 9, 2023
jonko0493 added a commit that referenced this issue Apr 9, 2023
@github-project-automation github-project-automation bot moved this from In PR to Done in Serial Loops Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Used for critical bugs (things that are causing crashes) macos Used on issues that affect macOS specifically
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants