Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery Using Mnemonic #305

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Recovery Using Mnemonic #305

merged 1 commit into from
Oct 10, 2024

Conversation

sunwavesun
Copy link
Collaborator

Updated features for hmy keys recover-from-mnemonic:

  • The coinType flag is used when performing key derivation from mnemonic.
    • BIP 44 uses key derivation to generate multiple keys from a single mnemonic for different cryptocurrencies. The coinType flag specifies which cryptocurrency's keys to derive (e.g., 1023 for Harmony, 60 for Ethereum).
    • Required for Metamask mnemonic, as they use type coin type 60 across all networks.
  • The index flag is used to specify which key is to be recovered from mnemonic.

logic update for recovering keys using mnemonics
6c0174e 
index flag when recovering keys
@sunwavesun sunwavesun merged commit b40966e into master Oct 10, 2024
2 checks passed
@sunwavesun sunwavesun deleted the mnemonic branch October 10, 2024 01:40
@GheisMohammadi GheisMohammadi self-requested a review October 10, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frozen Frozen Frozen approved these changes

@GheisMohammadi GheisMohammadi Awaiting requested review from GheisMohammadi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunwavesun @Frozen