Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix broken Chromedriver #53

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

echoy-harmonicinc
Copy link

No description provided.

GitHub started installing "Chrome for Testing" builds on Windows and
Mac. Unfortunately, these builds don't have support for H264 and AAC
codecs, which we need in our tests.

This fixes the issue by explicitly installing an official build of
Chrome on Windows, to overwrite the "Chrome for Testing" build.
# Conflicts:
#	.github/workflows/build-and-test.yaml
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment)

This also incorporates
shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs.
# Conflicts:
#	build/shaka-lab.yaml
#	package-lock.json
#	package.json
@echoy-harmonicinc echoy-harmonicinc changed the title [Test only] CI fix ci: Fix broken Chromedriver Sep 27, 2023
@echoy-harmonicinc echoy-harmonicinc merged commit ea2297f into harmonic-v4.0.x Sep 27, 2023
@echoy-harmonicinc echoy-harmonicinc deleted the feature/echoy/ci-fix branch September 27, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants