fix: rtmp: read timeout #67 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanc
reviewed
Oct 27, 2023
library/bytesio/src/bytesio.rs
Outdated
| } | ||
| }, | ||
| Err(_) => { |
There was a problem hiding this comment.
在BytesIOError里面可以定义一个tokio::time::error::Elapsed 枚举类型，然后可以把这个error传递出去。
harlanc
reviewed
Oct 27, 2023
library/bytesio/src/bytesio.rs
Outdated
| loop { | ||
| match self.read().await { | ||
| match tokio::time::timeout(duration, self.read()).await { |
There was a problem hiding this comment.
这段写法可以再简化一下吧，像下面这样，loop是不是也没用了？
match tokio::time::timeout(duration, self.read()).await {
Ok(data) => data,
Err(err) => Err(BytesIOError {
value: BytesIOErrorValue::TimeoutError(err),
}),
}
|
Thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 #67 中因阻塞导致超时断开链接逻辑未能正确执行以及异常信息被覆盖的问题