Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect using url config key #256

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: redirect using url config key #256

merged 1 commit into from
Jun 24, 2024

Conversation

94726
Copy link
Contributor

@94726 94726 commented Jun 22, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR changes the redirect to use the site.url config.

According to the docs, redirectToCanonicalSiteUrl redirects to the default canonical url, which is supposed to be site.url, not site.site

Copy link

vercel bot commented Jun 22, 2024

@94726 is attempting to deploy a commit to the My Team Team on Vercel.

A member of the Team first needs to authorize it.

@harlan-zw
Copy link
Owner

πŸ€¦β€β™‚οΈ thanks for spotting this and the fix!

@harlan-zw harlan-zw merged commit 2f195e4 into harlan-zw:main Jun 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants