Upgrade to Django 3.2 #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 3.2 has a built-in pymemcache-based cache backend
shaib
commented
Oct 6, 2021
| @@ -36,7 +35,7 @@ | |||
| packages=find_packages(exclude=('tests',)), | |||
| include_package_data=True, | |||
| install_requires=[ | |||
| 'django-pymemcache>=1.0', | |||
| 'Django>=2.2', | |||
| 'pymemcache==3.3.0', | |||
There was a problem hiding this comment.
I'd prefer a newer version like 3.5.0 but pinterest/pymemcache#353 causes breakage so I stick with a version that's been used before
Surgo
approved these changes
Oct 6, 2021
|
@shaib Thank you for you contribute :) |
|
I'll fix CI issues and then merge this. |
|
Any luck on getting this merged and in a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, IMO, the minimal change required for proper support Django>=3.2, fixing #170.
Note: No effort has been made to keep support of older Django versions -- none of them have more than a few months before EOL.