Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic after connection time out #29

Closed
harenber opened this issue May 10, 2020 · 1 comment
Closed

panic after connection time out #29

harenber opened this issue May 10, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@harenber
Copy link
Owner

pi@funkpi:~/go/src/github.com/la5nta/pat $ ./pat connect "pactor:///HB9MM"
2020/05/10 15:37:18 Connecting to HB9MM (pactor)...
panic: runtime error: slice bounds out of range [2:0]

goroutine 9 [running]:
github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc.(*Modem).getChannelsStatus(0x1516140, 0x1f, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1313, 0x1)
	/home/pi/go/src/github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc/modem.go:612 +0x334
github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc.(*Modem).updatePactorState(0x1516140, 0x0, 0x0)
	/home/pi/go/src/github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc/modem.go:465 +0x24
github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc.(*Modem).statusThread(0x1516140)
	/home/pi/go/src/github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc/modem.go:255 +0x38
created by github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc.(*Modem).runControlLoops
	/home/pi/go/src/github.com/la5nta/pat/vendor/github.com/harenber/ptc-go/ptc/modem.go:238 +0x48
@harenber harenber added the bug Something isn't working label May 10, 2020
@harenber harenber self-assigned this May 10, 2020
@harenber
Copy link
Owner Author

Seems the internal 100ms wait time is too small. With 200ms it never appeared again in my tests. Nevertheless, a code should never panic, wrote a check for that. Waiting to be checked in...

harenber added a commit that referenced this issue May 30, 2020
This is a new release that brings:

- support for PACTOR-4 Dragon modems #3
- support for CRC Hostmode instead of plain WA8DED hostmode
- adds a license #28, #27
- follows LA5NTA to move to Go modules la5nta/pat#199

most changes are done in modem.go, most notably:

- the underlying serial library has changed
- a lot of helper functions were added to support the CRC Hostmode
- handling of interrupted system calls on the serial line
- small bug fixes, especially #29
harenber added a commit that referenced this issue May 30, 2020
This is a new release that brings:

- support for PACTOR-4 Dragon modems
#3
- support for CRC Hostmode instead of plain WA8DED hostmode
- adds a license #28,
#27
- follows LA5NTA to move to Go modules
la5nta/pat#199

most changes are done in modem.go, most notably:

- the underlying serial library has changed
- a lot of helper functions were added to support the CRC Hostmode
- handling of interrupted system calls on the serial line
- small bug fixes, especially
#29
@harenber harenber closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant