Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes after screen wakeup on Ubuntu 19.10 #174

Closed
loxK opened this issue Apr 30, 2020 · 10 comments
Closed

Crashes after screen wakeup on Ubuntu 19.10 #174

loxK opened this issue Apr 30, 2020 · 10 comments

Comments

@loxK
Copy link

loxK commented Apr 30, 2020

I get this error:

JS ERROR: Extension [email protected]: Error: Argument 'actor' (type interface) may not be null
                                           init/Clutter.Actor.prototype.toString@resource:///org/gnome/shell/ui/environment.js:243:16
                                           registerHandler@/home/lox/.local/share/gnome-shell/extensions/[email protected]/handlers.js:54:20
                                           connect@/home/lox/.local/share/gnome-shell/extensions/[email protected]/handlers.js:71:12
                                           _init@/home/lox/.local/share/gnome-shell/extensions/[email protected]/window.js:337:7
                                           _init@/home/lox/.local/share/gnome-shell/extensions/[email protected]/extension.js:13:28
                                           enable@/home/lox/.local/share/gnome-shell/extensions/[email protected]/extension.js:39:18
                                           _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:149:13
                                           loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:281:21
                                           callback@resource:///org/gnome/shell/ui/extensionDownloader.js:244:17
                                           gotExtensionZipFile/<@resource:///org/gnome/shell/ui/extensionDownloader.js:108:13

@jonian
Copy link
Member

jonian commented Apr 30, 2020

Hi @loxK, thanks for the report. Have you tried with the master branch? Also is this on wayland, xorg or both?

@loxK
Copy link
Author

loxK commented May 3, 2020

I didn't try master and it is on xorg

@loxK
Copy link
Author

loxK commented May 7, 2020

More information. It works on boot but then crashes when waking up the screen. Restarting Gnome Shell doesn't help, uninstalling, reinstalling doesn't either.

This is maybe related ? ubuntu/gnome-shell-extension-appindicator#228

@loxK loxK changed the title Installation fails on Ubuntu 19.10 Crashes after screen wakeup on Ubuntu 19.10 May 7, 2020
@jonian
Copy link
Member

jonian commented May 7, 2020

Try replacing in handlers.js file in registerHandler function:

// Replace this line
const key = `${object}[${name}]`

// With these
const uid = Math.random().toString(36).substr(2, 9)
const key = `${uid}-${name}`

Please report back if the issue is fixed.

@loxK
Copy link
Author

loxK commented May 9, 2020

Made the change, rebooted, locked the screen and the extension is still active on login in.
It seems fixed. Thks!

@loxK
Copy link
Author

loxK commented May 9, 2020

Damn it crashed again and I don't find any occurrence of 'unite' in the shell logs ..., But I was able to uninstall/reinstall and activate it again this time.

jonian added a commit that referenced this issue May 11, 2020
@loxK
Copy link
Author

loxK commented May 13, 2020

I have applied the fix but it still crashes sometimes:


JS ERROR: Extension [email protected]: Error: Argument 'instance' (type interface) may not be null
                                        disconnect@/home/lox/.local/share/gnome-shell/extensions/[email protected]/handlers.js:77:7
                                        disconnectAll@/home/lox/.local/share/gnome-shell/extensions/[email protected]/handlers.js:89:7
                                        destroy@/home/lox/.local/share/gnome-shell/extensions/[email protected]/window.js:451:7
                                        destroy@/home/lox/.local/share/gnome-shell/extensions/[email protected]/extension.js:31:7
                                        disable@/home/lox/.local/share/gnome-shell/extensions/[email protected]/extension.js:44:3

gnome-software[12733]: unite_hardpixel.eu has error: Error: Argument 'instance' (type interface) may not be null

@loxK
Copy link
Author

loxK commented May 15, 2020

It happens when the screen goes black, not on session lock/unlock

@loxK
Copy link
Author

loxK commented May 27, 2020

This may be related, or not ... You tell me https://bugzilla.gnome.org/show_bug.cgi?id=781760

@jonian
Copy link
Member

jonian commented Feb 5, 2021

Closing as I can't reproduce this issue. If it is still present please open a new issue with fresh logs.

@jonian jonian closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants