Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add can bridge #1923

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Add can bridge #1923

wants to merge 34 commits into from

Conversation

pkess
Copy link
Contributor

@pkess pkess commented Feb 22, 2025

Hello,

it might be useful to have the possibility to use the RedirectReader in a script so that one can connect two can busses with a single cli program. This is extremly helpful if one would like to connect e.g. socketcand with a proprietary hardware interface.

Comments are appreciated

@zariiii9003
Copy link
Collaborator

I think this is may be very useful 👍

Not a review yet, but a few notes:

  • New code should have type annotations, at least for the function signatures.
  • The other CLI tools have tests in test_scripts.py and e.g. test_player.py, test_logger.py etc., i think this bridge could also be tested with two virtual buses.
  • Minor: I think the plural of bus is usually buses, not busses 🤷‍♂️

@pkess
Copy link
Contributor Author

pkess commented Feb 23, 2025

Ok. I will work on all those three

@pkess
Copy link
Contributor Author

pkess commented Feb 23, 2025

I addes some very basic tests now. I do not know at the moment how to test that a message that was received on one bus is forwarded to the other bus. Maybe i can try this again in the next days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants