New async io interfaces #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cargo fmt check failed |
|
I requested source code comments stating, why the // SAFETY: the following unsafe section is safe, because .... |
I understand now. |
|
Just checking if there's anything else I need to do to get this merged? Happy to get started on it ASAP :) |
haraldh
approved these changes
Dec 1, 2023
|
Maybe rebase on the current master and squash some commits |
…ocket This allows callers of uds_windows to potentially avoid having to use the Raw types and traits. This also allows the use of uds_windows with upcoming changes to async-io to use AsFd. Get compiling from old PR; add AsSocket for UnixStream Cargo format
TTWNO
force-pushed
the
new_async_io_interfaces
branch
from
a223023 to
85e95bc
Compare
|
Done! |
|
Thanks! |
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix-up of #8
I understand you requested safety comments, however, it appears that safety comments are being generated for parts of the code unchanged by this PR.