Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TLS verification from SPOE #52

Merged
merged 1 commit into from
May 26, 2020
Merged

Disable TLS verification from SPOE #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 18 additions & 28 deletions haproxy/spoe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,39 +42,29 @@ func (h *SPOEHandler) Handler(args []spoe.Message) ([]spoe.Action, error) {
return nil, errors.Wrap(err, "spoe handler")
}

_, err = cert.Verify(x509.VerifyOptions{
Roots: cfg.CAsPool,
})
if err != nil {
log.Warnf("connect: error validating certificate: %s", err)
}

authorized := err == nil
sourceApp := ""

if authorized {
certURI, err := connect.ParseCertURI(cert.URIs[0])
if err != nil {
log.Printf("connect: invalid leaf certificate URI")
return nil, errors.New("connect: invalid leaf certificate URI")
}
certURI, err := connect.ParseCertURI(cert.URIs[0])
if err != nil {
log.Printf("connect: invalid leaf certificate URI")
return nil, errors.New("connect: invalid leaf certificate URI")
}

// Perform AuthZ
resp, err := h.c.Agent().ConnectAuthorize(&api.AgentAuthorizeParams{
Target: cfg.ServiceName,
ClientCertURI: certURI.URI().String(),
ClientCertSerial: connect.HexString(cert.SerialNumber.Bytes()),
})
if err != nil {
return nil, errors.Wrap(err, "spoe handler: authz call failed")
}
// Perform AuthZ
resp, err := h.c.Agent().ConnectAuthorize(&api.AgentAuthorizeParams{
Target: cfg.ServiceName,
ClientCertURI: certURI.URI().String(),
ClientCertSerial: connect.HexString(cert.SerialNumber.Bytes()),
})
if err != nil {
return nil, errors.Wrap(err, "spoe handler: authz call failed")
}

log.Debugf("spoe: auth response from %s authorized=%v", certURI.URI().String(), resp.Authorized)
log.Debugf("spoe: auth response from %s authorized=%v", certURI.URI().String(), resp.Authorized)

authorized = resp.Authorized
if sis, ok := certURI.(*connect.SpiffeIDService); ok {
sourceApp = sis.Service
}
authorized := resp.Authorized
if sis, ok := certURI.(*connect.SpiffeIDService); ok {
sourceApp = sis.Service
}

res := 1
Expand Down