Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme with full usage #20

Merged

Conversation

pierresouchay
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@aiharos aiharos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pierre,
Just some minor things to check and correct maybe.

haproxy/haproxy_cmd/run.go Outdated Show resolved Hide resolved
consul/logger.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pierresouchay pierresouchay force-pushed the updated_readme_with_full_usage branch from 3979ea8 to e26a198 Compare April 15, 2020 09:38
@pierresouchay pierresouchay requested a review from aiharos April 15, 2020 09:39
@pierresouchay
Copy link
Collaborator Author

@aiharos All clean now

@aiharos aiharos dismissed their stale review April 15, 2020 10:18

updated the README.md through the suggestion

@aiharos
Copy link
Collaborator

aiharos commented Apr 15, 2020

@aiharos All clean now

Yup, looks good, merging.

@aiharos aiharos merged commit 35f0997 into haproxytech:master Apr 15, 2020
@pierresouchay pierresouchay deleted the updated_readme_with_full_usage branch April 15, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants