Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--WibbleRemover causes hedgehogging #492

Open
Gamnn opened this issue May 25, 2020 · 7 comments
Open

--WibbleRemover causes hedgehogging #492

Gamnn opened this issue May 25, 2020 · 7 comments
Labels
enhancement ld-decode An issue only affecting the ld-decode[r]

Comments

@Gamnn
Copy link
Contributor

Gamnn commented May 25, 2020

This clip decodes fine normally, but breaks when using --WibbleRemover:

ld-decode -nj issue492.ldf clip
file frame 1 CAV frame 322
file frame 2 CAV frame 323
file frame 3 CAV frame 324
file frame 4 CAV frame 325
file frame 5 CAV frame 326
file frame 6 CAV frame 327
file frame 7 CAV frame 328
file frame 8 CAV frame 329
file frame 9 CAV frame 330
file frame 10 CAV frame 331
file frame 11 CAV frame 332
file frame 12 CAV frame 333
file frame 13 CAV frame 334
file frame 14 CAV frame 335
saving JSON and exiting

ld-decode -nj issue492.ldf clip --WibbleRemover
file frame 1 CAV frame 322
file frame 2 CAV frame 323
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
file frame 3 CAV frame 324
file frame 4 CAV frame 325
file frame 5 CAV frame 326
file frame 6 CAV frame 327
file frame 7 CAV frame 328
file frame 8 CAV frame 329
file frame 9 CAV frame 330
file frame 10 CAV frame 331
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
file frame 11 CAV frame 332
file frame 12 CAV frame 333
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
WARNING:root:NTSC field phaseID sequence mismatch (player may be paused)
file frame 13 CAV frame 334
file frame 14 CAV frame 335
saving JSON and exiting

issue492.zip

@happycube
Copy link
Owner

Looking at the line scope (line 39 is good for this) the disk already has a rather soft signal and does not need WibbleRemover. On NTSC there are only some disks with high noise that need it.

@Gamnn
Copy link
Contributor Author

Gamnn commented May 28, 2020

Seems you're right. A different capture of a matching disc on an HLD-X9 required --WibbleRemover and it functioned without problem, but this capture from a CLD-5000(?) didn't need it. Closing.

@Gamnn Gamnn closed this as completed May 28, 2020
@happycube
Copy link
Owner

happycube commented May 28, 2020 via email

@Gamnn
Copy link
Contributor Author

Gamnn commented May 28, 2020

@Gamnn
Copy link
Contributor Author

Gamnn commented Jun 10, 2020

Re-opening Another disc does need --WibbleRemover regardless of player, and likewise causes the hedgehogging at the start of the disc (Mostly around frame 300) for most of the captures, other than the x9's. Will PM with captures of the affected area and a wibbly area.

@Gamnn Gamnn reopened this Jun 10, 2020
@happycube
Copy link
Owner

happycube commented Jun 14, 2020

Partially fixed by latest commit - the disk in question needs deemphasis reduced to .65x normal (-d .65) - won't close until auto-tuning is implemented though.

@simoninns simoninns added enhancement ld-decode An issue only affecting the ld-decode[r] labels Jul 30, 2020
@Gamnn
Copy link
Contributor Author

Gamnn commented Dec 6, 2020

An update on this, rezo found the discs in this series now turn green (and no longer hedgehogs) since commit #7c6d913 unless -d .65 is specified. (even without using --NTSC_color_notch_filter/formerly --Wibble-remover)

I haven't given it a full disc decode to see if -d .65 works across the whole disc yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ld-decode An issue only affecting the ld-decode[r]
Projects
None yet
Development

No branches or pull requests

3 participants