Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transitive dependency missing #73

Closed
ahuth opened this issue May 2, 2019 · 4 comments · Fixed by #74
Closed

Transitive dependency missing #73

ahuth opened this issue May 2, 2019 · 4 comments · Fixed by #74

Comments

@ahuth
Copy link

ahuth commented May 2, 2019

After https://www.npmjs.com/advisories/830, it looks like all but the latest version of Ecstatic was removed from NPM (see jfhbrook/node-ecstatic#255). This is an issue because it's a dependency of http server (http-party/http-server#521), which is a dependency of happo.io.

Because of this, I'm unable to install the package. The only solution may be to ensure that http-server is updated here, once they update.
@ahuth ahuth changed the title Transitive dependency causing problems Transitive dependency missing May 2, 2019
@trotzig
Copy link
Contributor

trotzig commented May 2, 2019

Thanks for making me aware of this problem. The http-server dependency isn't vital for main happo execution (it is only used for happo debug), I think I can ditch that dependency temporarily.

trotzig added a commit that referenced this issue May 2, 2019
@trotzig
Temporarily remove usage of http-server
d3f87fa 
A dependency of http-server was removed from npm. As a result, all
http-server installations currently fail. While we wait for a fix, we
can temporarily remove our usage of http-server. Only the `happo debug`
command is affected, which I think is okay.

Fixes #73

See http-party/http-server#521 for context.
trotzig added a commit that referenced this issue May 2, 2019
@trotzig
Temporarily remove usage of http-server
105282e 
A dependency of http-server was removed from npm. As a result, all
http-server installations currently fail. While we wait for a fix, we
can temporarily remove our usage of http-server. Only the `happo debug`
command is affected, which I think is okay.

Fixes #73

See http-party/http-server#521 for context.
@trotzig trotzig mentioned this issue May 2, 2019
Merged
@trotzig
Copy link
Contributor

trotzig commented May 2, 2019

The fix was released in v3.14.0 - https://www.npmjs.com/package/happo.io/v/3.14.0

@ahuth
Copy link
Author

ahuth commented May 2, 2019

Thanks!

@thornjad
Copy link

thornjad commented May 2, 2019

jfhbrook/node-ecstatic#256 will fix http-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporarily remove usage of http-server happo/happo.io
3 participants
@trotzig @ahuth @thornjad