Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer piping of options.payload until socket connection #223

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Defer piping of options.payload until socket connection #223

merged 2 commits into from
Jul 24, 2018

Conversation

ggoodman
Copy link
Contributor

Fixes #222.

@ggoodman
Copy link
Contributor Author

I've investigated why this is failing on travis against node@10. It turns out that a change was introduced in the order of stream events in 10.2 that will be backed out and deferred until 11.x.

See: nodejs/node#20611 (comment) and the work to revert this change: nodejs/node#21809.

@geek geek self-assigned this Jul 23, 2018
@geek geek self-requested a review July 23, 2018 23:08
@geek geek added feature New functionality or improvement bug Bug or defect and removed feature New functionality or improvement labels Jul 23, 2018
@geek geek added this to the 14.0.3 milestone Jul 24, 2018
@geek geek merged commit 1315545 into hapijs:master Jul 24, 2018
@geek
Copy link
Member

geek commented Jul 24, 2018

@ggoodman Going to look into potential workarounds for the node 10 regression before publishing.

@geek
Copy link
Member

geek commented Jul 24, 2018

@ggoodman I do have a workaround, but it feels hacky for this special case... going to wait until the next 10.x release, which should include the regression fix.

@geek geek mentioned this pull request Jul 24, 2018
Merged
@geek
Copy link
Member

geek commented Jul 24, 2018

@ggoodman if you are curious on the workaround #224

@ggoodman ggoodman mentioned this pull request Jul 24, 2018
Merged
3 tasks
@ggoodman ggoodman deleted the fix-pipe-after-socket-connect branch July 24, 2018 15:41
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geek geek Awaiting requested review from geek

Assignees

@geek geek

Labels
bug Bug or defect
Projects
None yet
Milestone
14.1.0
Development

Successfully merging this pull request may close these issues.

Investigate only piping the payload after a connection is established
2 participants
@ggoodman @geek