Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and deprecation warning #665

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Fix test and deprecation warning #665

merged 2 commits into from
Jan 12, 2017

Conversation

geek
Copy link
Member

@geek geek commented Jan 12, 2017

No description provided.

@geek geek added the test Test or coverage label Jan 12, 2017
@geek geek added this to the 11.2.2 milestone Jan 12, 2017
@geek geek self-assigned this Jan 12, 2017
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geek geek merged commit ffe0618 into hapijs:master Jan 12, 2017
@geek geek deleted the fixes branch January 12, 2017 15:25
@@ -623,7 +623,7 @@ describe('CLI', () => {
let filename;
beforeEach((done) => {

filename = Path.join(Os.tmpDir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
filename = Path.join(Os.tmpdir(), [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-'));
Copy link
Contributor

@arb arb Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoek has a unique file name function.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Test or coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants