Use getValueAsString for DateTimeType conversions #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe-conversion-via-stringvalue
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
============================================
+ Coverage 9.62% 9.70% +0.07%
- Complexity 12875 12880 +5
============================================
Files 2198 2198
Lines 911470 911377 -93
Branches 273323 273224 -99
============================================
+ Hits 87745 88463 +718
+ Misses 790183 789401 -782
+ Partials 33542 33513 -29
Continue to review full report at Codecov.
|
dotasek
changed the title
Use Base64Binary getValue for Base64 conversion instead of getValueAsString.
Since Uuids extend UriType, it was always gettting treated as a Uri instead of a Uuid
…pe-conversion-via-stringvalue
Add changes for canonical
grahamegrieve
deleted the
dotasek-primitivetype-conversion-via-stringvalue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all BaseDateTimeType extension conversions to use getValueAsString instead of getValue in order to preserve precision when converting.