Fix split logic of canonical into url and version in several places #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed - org.hl7.fhir.r4b.renderers.DataRenderer#versionFromCanonical - org.hl7.fhir.r4b.renderers.DataRenderer#systemFromCanonical - org.hl7.fhir.r5.renderers.DataRenderer#versionFromCanonical - org.hl7.fhir.r5.renderers.DataRenderer#systemFromCanonical The logic of these methods is wrong, the functionality of extracting the version and the system URL have been swapped. Therefore, all usages of aforementioned methods were replaced by the use of org.hl7.fhir.utilities.CanonicalPair. This not only fixes the problem, but also reduces duplicated functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1619 +/- ##
=========================================
Coverage 12.18% 12.18%
- Complexity 31581 31588 +7
=========================================
Files 2182 2182
Lines 671491 671479 -12
Branches 198194 198191 -3
=========================================
+ Hits 81846 81850 +4
+ Misses 560217 560206 -11
+ Partials 29428 29423 -5 ☔ View full report in Codecov by Sentry. |
dotasek
approved these changes
Jun 19, 2024
|
@Boereck thanks for closing! I was looking for this today after the master branch built and wondered where it disappeared to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
The logic of these methods is wrong, the functionality of extracting the version and the system URL have been swapped.
Therefore, all usages of aforementioned methods were replaced by the use of
org.hl7.fhir.utilities.CanonicalPairinorg.hl7.fhir.r4b.renderers.TerminologyRendererandorg.hl7.fhir.r5.renderers.TerminologyRenderer. This not only fixes the problem, but also reduces duplicated functionality.The test case for this change was proposed to the test repository in PR FHIR/fhir-test-cases#172 .
This PR closes the second round of errors found in issue #1611 . After this PR, all found bugs are taken care of.