Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps isBase64 with internal implementation for Android compatibility #1079

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

dotasek
Copy link
Collaborator

@dotasek dotasek commented Jan 18, 2023

Fixes #1046 by duplicating a portion of the newer Apache codec api.

Differs from the similar PR #1051 in that it doesn't use a deprecated method.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 9.93% // Head: 9.93% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (32857c5) compared to base (a24add4).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1079   +/-   ##
=========================================
  Coverage      9.93%    9.93%           
  Complexity    13200    13200           
=========================================
  Files          2483     2484    +1     
  Lines        976377   976387   +10     
  Branches     290293   290294    +1     
=========================================
+ Hits          96988    97010   +22     
+ Misses       842233   842223   -10     
+ Partials      37156    37154    -2     
Impacted Files Coverage Δ
...s/src/main/java/org/hl7/fhir/utilities/Base64.java 90.00% <90.00%> (ø)
.../java/org/hl7/fhir/r4b/model/Base64BinaryType.java 80.00% <100.00%> (ø)
...n/java/org/hl7/fhir/r5/model/Base64BinaryType.java 82.85% <100.00%> (ø)
...java/org/hl7/fhir/r5/context/TerminologyCache.java 69.09% <0.00%> (+0.24%) ⬆️
...a/org/hl7/fhir/r5/test/utils/CompareUtilities.java 59.15% <0.00%> (+1.87%) ⬆️
.../fhir/utilities/tests/CacheVerificationLogger.java 20.83% <0.00%> (+8.33%) ⬆️
...c/main/java/org/hl7/fhir/utilities/FileFormat.java 77.77% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isBase64 is not available on Android (Use java.util.Base64)
3 participants