Making sure that we are not accidentally overwriting an existing reso…

[jkiddo]

…urce with the same ID from another IG by comparing identifier, url or whatever constitutes uniqueness.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (406db33) to head (698c821).
Report is 38 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6291      +/-   ##
============================================
+ Coverage     83.54%   83.58%   +0.04%     
- Complexity    27432    27562     +130     
============================================
  Files          1707     1715       +8     
  Lines        106185   106675     +490     
  Branches      13397    13434      +37     
============================================
+ Hits          88710    89169     +459     
+ Misses        11750    11746       -4     
- Partials       5725     5760      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jkiddo]

@codeforgreen can I persuade you to have a look at this?

[jkiddo]

Ping @codeforgreen ?

[codeforgreen]

Ping @codeforgreen ?

HI @jkiddo what is this related to? The title of this issue does not ring a bell to me. Can you provide more details and link any related issue or pull request? Thanks.
Do you just want me to review your changes?

[jkiddo]

An issue I discovered in the starter project using the IG installer functionality. If you install multiple IGs with overlapping resources then the order of installing suddenly starts to play a part which it shouldnt. This PR makes sure that all resources are installed using conditional logic and stops that non deterministic behaviour. So yes, please review/comment/merge.

[jkiddo]

@codeforgreen does the above provide the needed clarity?

[dotasek]

Where would update(T theResource, String theMatchUrl, RequestDetails theRequestDetails); actually throw the exceptions that you're queueing in the mock?

theMatchUrl is different for oldSpec and newSpec. Where is the logic that would throw this exception?

[jkiddo]

@dotasek the error will be thrown in

hapi-fhir/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/JpaResourceDaoCodeSystem.java

Line 252 in 8676cf2

myTerminologyCodeSystemStorageSvc.storeNewCodeSystemVersionIfNeeded(

I've added this test here https://github.com/hapifhir/hapi-fhir/pull/6291/files#diff-aa258240972be5bb70e69c9bb6ff0a8cd9ea9a93815c0d1e79e4cf446986f789R273 that might better explain and reproduce it.