Clear all connections in SessionManager during HomekitRoot.stop() #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's lot of inconsistent uses of tabs vs spaces throughout the project, and this is leading to some weird diffs. I submit the project should just enforce formatting during compile time and just remove any doubt. This way contributors won't need to update their Eclipse configuration to match, as long as they run mvn compile, it'll format correctly.
This is a potential fix for hap-java#54
|
Just rerunning the CI on this after merging #53, then I'll merge this as well. |
|
@beowulfe I wasn't sure if this was the ideal way to solve this and was hoping to get your opinion on it first; I guess it seemed like a reasonable solution? :) |
|
@timcharper - yep, I think it's great. I've used checkstyle in the past, but I don't have an opinion on it vs google's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve issue #54, which I've observed during development of the Openhab2 homekit addon.