Add separate metrics for non-numeric fields #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present textual fields are reported as labels on the info metric where every change creates a new time series. They should be reported as separate metrics instead.
The flag has no implementation yet. That will follow in a separate commit.
Every report group (PV, VG, LV) had its own info metric where non-numeric fields like `pv_attr` were reported as a label. Every unique combination of labels produces a new time series. From https://prometheus.io/docs/practices/naming/#labels: > Remember that every unique combination of key-value label pairs > represents a new time series, which can dramatically increase the > amount of data stored. Do not use labels to store dimensions with high > cardinality (many different label values), such as user IDs, email > addresses, or other unbounded sets of values. With this change the labels on the info metrics are reduced to names (e.g. `pv_name` and `lv_full_name`). Everything else is moved to separate metrics. A command line flag, enabled by default, retains the labels on the info metric. Related to issue #31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every report group (PV, VG, LV) had its own info metric where
non-numeric fields like
pv_attrwere reported as a label. Every uniquecombination of labels produces a new time series. From
https://prometheus.io/docs/practices/naming/#labels:
With this change the labels on the info metrics are reduced to names
(e.g.
pv_nameandlv_full_name). Everything else is moved toseparate metrics.
A command line flag, enabled by default, retains the labels on the info
metric.