Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intersect trait; rename intersection module to intersect #946

Merged
merged 4 commits into from
Aug 12, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/fj-kernel/src/algorithms/cast_ray/mod.rs
Original file line number Diff line number Diff line change
@@ -8,6 +8,14 @@ pub use self::segment::RaySegmentHit;
use fj_math::Point;

/// Implemented by types that support ray casting
///
/// # Implementation Note
///
/// This is basically a more limited version of [`Intersect`]. It probably makes
/// sense to migrate all of this trait's implementations to [`Intersect`] and
/// remove this trait.
///
/// [`Intersect`]: super::intersect::Intersect
pub trait CastRay<const D: usize> {
/// The type that describes a hit of the ray on the implementing type
type Hit;
8 changes: 8 additions & 0 deletions crates/fj-kernel/src/algorithms/contains/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
mod face_point;

/// Test whether an object or shape contains another
///
/// # Implementation Note
///
/// This is basically a more limited version of [`Intersect`]. It probably makes
/// sense to migrate all of this trait's implementations to [`Intersect`] and
/// remove this trait.
///
/// [`Intersect`]: super::intersect::Intersect
pub trait Contains<T> {
/// Test whether an object or shape contains another
///