Replace Curve with Curve/GlobalCurve/CurveKind
#900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm about to complement it with two new types, one of them to be named `Curve`.
This makes changes I'm working on a bit easier. It can be re-added as required.
They now follow the current convention.
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings curves in line with the way vertices already work. It also makes code that has to handle curves in multiple forms a bit easier.
It's unfortunate that this introduces the redundancy between the
CurveKinds ofCurveandGlobalCurve, but I don't think it is a problem right now. If it becomes one, it can be handled with validation (which it should be eventually anyways). Long-term, I can imagine thatCurveKindwon't be a thing any more, because every curve will be a b-spline, but we'll see how that's going to develop.