Remove FaceBuilder
#864
Merged
Remove FaceBuilder
#864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the API simpler and more modular, at the cost of some convenience. But my actual reason for doing this, is to bring the API closer to `Face`'s API, so I can make `FaceBuilder` completely redundant.
See previous commit for justification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all its uses with a combination of existing
FaceandCycleAPIs. The replacements are simpler and more modular, at the cost of making the building of faces a bit less convenient.I'm sure that eventually (possibly soon), we'll need some kind of builder API again, and this should bring back the convenience. For now, there's not much point in keeping
FaceBuilderaround though, and the new builder API will likely look very different anyway.