Make group and transform operations work on all shapes #825
+147
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distinction is overly restrictive, as it prevents the transform and group operations from working on 2D shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both group and transform only worked on 3D shapes, but there was no good reason for that. Both operations can work on 2D shapes just as well. This pull request simplifies the
fjcrate, mergingfj::Shape3dintofj::Shapeto remove the distinction between 3D shapes and shapes in general. This is probably not the structure we want to have long-term, but it will do for now.Please note that in the case of transform, these are still 3D transformations. The 2D objects it now support live in 3D space, so it makes sense to do it like this.
cc @U007D, who made me aware of this limitation