Put new validation infrastructure in place #705
Merged
+250
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's empty, for now, but I've added some documentation.
This is now documented in the `validation` module.
There's not really any drawback any more, and having them be conditionally available would cause some problems with the next step.
Nothing is actually validated yet using the new infrastructure. It's just a placeholder, and as a next step, in can be hooked into all the places that require validation. The actual validation code can be migrated from the old infrastructure later, piece by piece.
This is part of the migration to the new validation infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new validation infrastructure initially described in #696, and hooks it up where it needs to be. It doesn't actually do any validation yet (as the old validation infrastructure still exists, unchanged). This pull request just puts the foundations into place, to allow the validation code to be migrated to the new infrastructure.