Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x/y field of view conversion #614

Merged
merged 1 commit into from
May 23, 2022
Merged

Fix x/y field of view conversion #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/fj-viewer/src/graphics/transform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ impl Transform {
///
/// The returned transform is used for transforming vertices on the GPU.
pub fn for_vertices(camera: &Camera, aspect_ratio: f64) -> Self {
let field_of_view_in_y = camera.field_of_view_in_x() / aspect_ratio;
let field_of_view_in_y = 2.
* ((camera.field_of_view_in_x() / 2.).tan() / aspect_ratio).atan();

let transform = camera.camera_to_model().project_to_array(
aspect_ratio,
Expand Down