Simplify Store
#414
Merged
Simplify Store
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It stores geometric and topological objects. I believe the new name is clearer.
I'm working on some changes, and `Iter`'s lifetime is really getting in the way of progress here. I think dumbing `Iter` down, at the cost of an allocation, is the right move for now.
I'm working on some changes to `Store`, which will make the implementation of `iter_mut` quite difficult, maybe even impossible.
This is going to help with some further cleanups I'm working on. It should also make it possible to remove `Storage` (which contains the same construct), so there's potential that this move will reduce the overall overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal cleanup that simplifies
Storeand related code, paving the way for more changes. This came out of my work towards #105.