fix: align output names #409
Conversation
|
With this fix in place, only the YAML file in GitHub Actions is still stringly typed, i.e. https://github.com/hannobraun/Fornjot/blob/main/.github/workflows/cd.yml#L110 I do not yet have a good idea how to overcome that. |
|
For easier glance, this was the bug: |
when no release was detcetd, the output name was incorrect due to the usage of a stringly typed identifier. i implemented the outputs as an enum to overcome the issue.
hannobraun
force-pushed
the
release-operator-align-output-names
branch
from
7650fe7 to
ad2b233
Compare
There was a problem hiding this comment.
Thank you @hendrikmaus, looks good!
With this fix in place, only the YAML file in GitHub Actions is still stringly typed, i.e. https://github.com/hannobraun/Fornjot/blob/main/.github/workflows/cd.yml#L110
I do not yet have a good idea how to overcome that.
Maybe nothing we an do about it, except maybe move more CD logic out of GitHub Actions and into the release operator. No idea, if this is practical or even desirable.
|
By the way, I had to rebase due to #408 being merged. Will merge once CI is green. |
When no release was detected, the output name was incorrect due to the
usage of a stringly typed identifier. I implemented the outputs as an
enum to overcome the issue.