Add convenient APIs to build Vertex and Edge
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new "builder" APIs for
VertexandEdge, and introduces them into unit tests. This significantly cleans up some of the test code, and this pull request is only the beginning. These APIs have much more potential to further clean up test code.This has the side effect of replacing the convenience methods for constructing edges that
Topologyused to have, making theShapeAPI more regular, potentially allowing for further clean-ups there.This is part of my work towards #105. I will need to update the approximation code (and the approximation test suite) to make more progress there, and these new builder APIs make it much easier to update the tests, and thus the code overall.