Added platform trait and specific platforms implementations plust Hos… #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tPlatform to provide common api
hannobraun
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Thank you, @ozghimire! This looks great, about what I imagined.
I'm going to merge this as-is, as it provides a clear place for adding future platform-specific infrastructure, which I think is a clear improvement.
In addition, I've left some comments with ideas for improvements. Feel free to address those in a follow-up pull request, if you want!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides common api with platform traits for host platform. This resolves #36 .
@hannobraun let's review this and I will merge once this is ironed out.